Merged
Conversation
Commit f3a2613 introduces a problem with answering incoming re-INVITE manually by the app in cases, where the UAC receives the re-INVITE. Issue pjsip#3769
sauwming
previously approved these changes
Nov 16, 2023
nanangizz
reviewed
Dec 28, 2023
Member
nanangizz
left a comment
nanangizz
left a comment
There was a problem hiding this comment.
ups, just realized that review I wrote long time ago is actually not submitted (still in pending state :)
| if ((call->inv->role == PJSIP_ROLE_UAC && call->inv->state != PJSIP_INV_STATE_CONFIRMED) || | ||
| !call->inv->invite_tsx || | ||
| call->inv->invite_tsx->state >= PJSIP_TSX_STATE_COMPLETED) | ||
| { |
Member
There was a problem hiding this comment.
Instead of evaluating invite session role (call->inv->role), perhaps the original patch should evaluate invite transaction role call->inv->invite_tsx->role, this way it will work for inital & subsequent invite, so the check conditions should have been:
if (!call->inv->invite_tsx ||
call->inv->invite_tsx->role != PJSIP_ROLE_UAC ||
call->inv->invite_tsx->state >= PJSIP_TSX_STATE_COMPLETED)
sauwming
approved these changes
Jan 2, 2024
nanangizz
approved these changes
Jan 2, 2024
trengginas
pushed a commit
that referenced
this pull request
Mar 11, 2024
dshamaev-intermedia
pushed a commit
to intermedia-net/pjproject
that referenced
this pull request
Mar 22, 2024
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f3a2613 introduces a problem with answering incoming re-INVITE manually by the app in cases, where the UAC receives the re-INVITE.
Issue #3769