Skip to content

Incorrect pjlib-test on GitHub CI#3374

Merged
bennylp merged 3 commits intomasterfrom
pjlib-test-bug
Feb 10, 2023
Merged

Incorrect pjlib-test on GitHub CI#3374
bennylp merged 3 commits intomasterfrom
pjlib-test-bug

Conversation

@bennylp
Copy link
Copy Markdown
Member

@bennylp bennylp commented Feb 9, 2023

  • fix pjlib-test always returns success even on error
  • fix failing tests when pjlib-test is run on GitHub CI:
    • add --ci-mode argument to pjlib-test. Some tests become more lenient under this mode.
    • add pjlib-test-ci Makefile target,
    • modify CI to use make pjlib-test-ci rather than make pjlib-test

@bennylp bennylp marked this pull request as draft February 9, 2023 12:31
@bennylp bennylp changed the title pjlib-test always return success pjlib-test always returns success Feb 9, 2023
@bennylp bennylp self-assigned this Feb 9, 2023
@bennylp bennylp added this to the release-2.14 milestone Feb 9, 2023
@bennylp bennylp changed the title pjlib-test always returns success Incorrect pjlib-test on GitHub CI Feb 10, 2023
@bennylp bennylp marked this pull request as ready for review February 10, 2023 05:22
@bennylp bennylp merged commit de64969 into master Feb 10, 2023
@bennylp bennylp deleted the pjlib-test-bug branch February 10, 2023 10:22
BarryYin pushed a commit to BarryYin/pjproject that referenced this pull request Feb 3, 2026
* Fix pjlib-test not returning error on error

* Add --ci-mode in pjlib-test and pjlib-test-ci Makefile target

* Better sleep_duration_test(): more lenient under --ci-mode and stricter under normal mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants