Conversation
bennylp
left a comment
There was a problem hiding this comment.
For documentation purpose:
- Rename PJLIB_UTIL_UPNP to PJNATH_UPNP in upnp.h, and remove "ingroup PJ_PROTOCOLS"
- Add PJNATH_UPNP entry in pjnath/docs/doc_mainpage.h (under "The library provides the following main component groups")
|
🎊 So adding upnp candidates from libupnp will be supported? We use it to inject our candidates inside the ICE components. Finally, last question, will libpcp be planned? |
|
Also we have some complex mechanisms on our side, so I guess we will not use PJNATH_UPNP for a long time. For example, we pre-open some ports because some routers take > 400ms to open a port (which is long) |
|
No, currently UPnP is only used for simple UDP media and SIP transports. And right now we don't have plan to support PCP or PMP. |
|
ok! |
As a NAT traversal helper, UPnP (added in #3184) is better suited to be in pjnath, instead of pjlib-util.