Skip to content

Move UPnP to PJNATH#3195

Merged
sauwming merged 3 commits intomasterfrom
upnp-pjnath
Jul 29, 2022
Merged

Move UPnP to PJNATH#3195
sauwming merged 3 commits intomasterfrom
upnp-pjnath

Conversation

@sauwming
Copy link
Copy Markdown
Member

@sauwming sauwming commented Jul 29, 2022

As a NAT traversal helper, UPnP (added in #3184) is better suited to be in pjnath, instead of pjlib-util.

@sauwming sauwming added this to the release-2.13 milestone Jul 29, 2022
@sauwming sauwming self-assigned this Jul 29, 2022
Copy link
Copy Markdown
Member

@bennylp bennylp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For documentation purpose:

  • Rename PJLIB_UTIL_UPNP to PJNATH_UPNP in upnp.h, and remove "ingroup PJ_PROTOCOLS"
  • Add PJNATH_UPNP entry in pjnath/docs/doc_mainpage.h (under "The library provides the following main component groups")

Copy link
Copy Markdown
Member

@bennylp bennylp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@sauwming sauwming merged commit 8861441 into master Jul 29, 2022
@sauwming sauwming deleted the upnp-pjnath branch July 29, 2022 09:05
@AmarOk1412
Copy link
Copy Markdown
Contributor

🎊

So adding upnp candidates from libupnp will be supported? We use it to inject our candidates inside the ICE components.
We also support NATPMP as a library which is pretty similar as some routers doesn't support one or the other (and on mobiles the support differs)

Finally, last question, will libpcp be planned?

@AmarOk1412
Copy link
Copy Markdown
Contributor

Also we have some complex mechanisms on our side, so I guess we will not use PJNATH_UPNP for a long time.
upnp can be slow depending on the version/implementation in the router (there is a lot of problems also, with limited pool, etc that we saw), so I guess it will take time before we switch anyway.

For example, we pre-open some ports because some routers take > 400ms to open a port (which is long)

@sauwming
Copy link
Copy Markdown
Member Author

sauwming commented Aug 2, 2022

No, currently UPnP is only used for simple UDP media and SIP transports.

And right now we don't have plan to support PCP or PMP.

@AmarOk1412
Copy link
Copy Markdown
Contributor

ok!

wosrediinanatour pushed a commit to wosrediinanatour/pjproject that referenced this pull request Jan 16, 2023
BarryYin pushed a commit to BarryYin/pjproject that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants