Merged
Conversation
sauwming
reviewed
Jul 5, 2022
pjlib/src/pj/ssl_sock_ossl.c
Outdated
| { \ | ||
| char err_str[PJ_ERR_MSG_SIZE]; \ | ||
| ERR_error_string_n(err, err_str, sizeof(err_str)); \ | ||
| char buf[PJ_INET6_ADDRSTRLEN+10]; \ |
Member
There was a problem hiding this comment.
move the variable declaration above? (i.e. swap L267 and L266)
Member
|
Make sure to test build and run with DTLS as well since it directly includes OpenSSL headers. |
Member
Author
|
Tested with enabling DTLS. |
sauwming
approved these changes
Jul 6, 2022
nanangizz
approved these changes
Jul 7, 2022
wosrediinanatour
pushed a commit
to wosrediinanatour/pjproject
that referenced
this pull request
Jan 16, 2023
* Support OpenSSL3 * Modify code order
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
* Support OpenSSL3 * Modify code order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add support to using OpenSSL 3 (ref).
Tested using OpenSSL 3.0.4 on Windows, MacOS, iOS, Android.
Modification:
ERR_func_error_string()PEM_read_bio_DHparams()SSL_CTX_set_tmp_dh()SHA256_Init()SHA256_Update(()SHA256_Final()This PR doesn't remove the build warning from
librtp.There's currently purpose fix for this.