Android - Create new ImageReader instance before opening camera#3063
Merged
sauwming merged 1 commit intopjsip:masterfrom Apr 14, 2022
Merged
Android - Create new ImageReader instance before opening camera#3063sauwming merged 1 commit intopjsip:masterfrom
sauwming merged 1 commit intopjsip:masterfrom
Conversation
sauwming
approved these changes
Apr 13, 2022
trengginas
approved these changes
Apr 13, 2022
nanangizz
pushed a commit
that referenced
this pull request
May 10, 2022
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing a couple Android devices using pjsip 2.12 with PjCamera2, one device, a Kyocera E6910 on Android 9, failed to send video or show local playback after switching cameras (back to front) in an active video stream.
It seems the underlying surface is being closed on camera switch. To resolve this, a new
ImageReaderinstance can be created before opening the camera. After a discussion with Ming, it was suggested to close theImageReaderonStop().With this change, testing shows video works well on the Kyocera and a Samsung Galaxy Note 9.