Prevent assertion when codec encoding height size is larger than wide size#3044
Merged
Prevent assertion when codec encoding height size is larger than wide size#3044
Conversation
sauwming
approved these changes
Apr 5, 2022
nanangizz
approved these changes
Apr 28, 2022
nanangizz
pushed a commit
that referenced
this pull request
May 10, 2022
BarryYin
pushed a commit
to BarryYin/pjproject
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2797 will replace Android Camera framework with Camera2.
After the changes, when codec encoding param height size is larger than width size (e.g: 480x720) assertion will be raised:
This is caused the width and height might get switched when creating the stream.