PJSUA automatically print call dump to log when media is stopped or restarted#2855
Merged
PJSUA automatically print call dump to log when media is stopped or restarted#2855
Conversation
sauwming
reviewed
Oct 19, 2021
| unsigned part_len; | ||
| unsigned part_idx; | ||
| unsigned log_decor; | ||
| char *buf; |
Member
There was a problem hiding this comment.
why does the buffer has to be dynamically allocated via the pool?
Member
Author
There was a problem hiding this comment.
when a large buffer is needed, typically allocated from heap (instead of stack which may have low size limit) is more friendly for embedded platforms. As this call dump is now part of the library, I think using heap is safer.
sauwming
approved these changes
Oct 19, 2021
trengginas
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #2600, printing end-of-call media stats can be a bit cumbersome for app when the call is video only and the call end is initiated by remote.
Also, some pjsua app may not print the end-of-call media stats while it is usually important in debugging media issues.