Skip to content

Support boot 3 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anthonydahanne wants to merge 3 commits into from
Closed

Support boot 3 #207

anthonydahanne wants to merge 3 commits into from

Conversation

@anthonydahanne
Copy link
Contributor

@anthonydahanne anthonydahanne commented Mar 15, 2023 •
edited
Loading

This is an initial PR

  • Spring Boot 3 Redis configuration (spring.data.redis) is now supported (maintaining SB 2 compatibility)
  • Tested with a sample SB3 project with a Redis service in Cloud Foundry TAS 3
[...]
   2023-03-15T16:57:17.64-0400 [APP/PROC/WEB/0] OUT :: Spring Boot ::                (v3.0.4)
   2023-03-15T16:57:18.03-0400 [APP/PROC/WEB/0] OUT 2023-03-15T20:57:18.027Z  INFO 7 --- [           main] o.s.c.SpringBootServiceProberApplication : Starting SpringBootServiceProberApplication v1.0.2-SNAPSHOT using Java 17.0.6 with PID 7 (/home/vcap/app/BOOT-INF/classes started by vcap in /home/vcap/app)
[...]
   2023-03-15T16:57:18.17-0400 [APP/PROC/WEB/0] OUT 2023-03-15T20:57:18.177Z  INFO 7 --- [           main] i.p.c.s.boot.CfEnvironmentPostProcessor  : Setting spring.data.redis properties from bound service [my-redis-service] using io.pivotal.cfenv.spring.boot.RedisCfEnvProcessor$Boot3
[...]
  org.springframework.cloud.RedisProber    : We could connect to Redis successfully to this URI: redis://************************************@10.0.8.36:46083
o.s.c.SpringBootServiceProberApplication : Started SpringBootServiceProberApplication in 11.199 seconds (process running for 12.755)

@anthonydahanne
Upgrade dependencies and tools
93ac6a0 
* CI should run on Java 17, it's an LTS version
* use more recent gradle to support Java 17
* Upgrade Spring boot version to latest bug fix
@anthonydahanne anthonydahanne mentioned this pull request Mar 15, 2023
Closed
@anthonydahanne anthonydahanne marked this pull request as ready for review March 16, 2023 17:47
Kehrlann
Kehrlann approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Kehrlann Kehrlann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tremblaysimon
Copy link

tremblaysimon commented Apr 14, 2023

Is there something missing to release a new version of java-cfenv with that PR?

@anthonydahanne
Copy link
Contributor Author

anthonydahanne commented Jun 5, 2023

allô @tremblaysimon,

Is there something missing to release a new version of java-cfenv with that PR?

we decided to branch the project to have 1 branch for Spring Boot2, and another branch (main branch) for Spring Boot 3.

It should happen hopefully this month, stay tuned!

PS: similar choice was taken for: spring-cloud/spring-cloud-bindings#94

@anthonydahanne
Copy link
Contributor Author

anthonydahanne commented Jun 7, 2023

The replacing PRs for the new branching model are created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kehrlann Kehrlann Kehrlann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anthonydahanne @tremblaysimon @Kehrlann