Skip to content

Conversation

@vaxerski
Copy link
Contributor

This cumbers the availability of the API and leads to bad requests that should not be bad.

I am building a reverse-proxy with pistache, and the client API cumbers my ability to do so properly:

  • The client API always drops the UA and replaces it with pistache's.
  • The client API always adds the Host header and this leads to bad requests when we want to set the host header manually.

In this MR, I drop both. Instead, pistache's UA and Host are added iff they are not added by the client.

@kiplingw kiplingw added bug http_client Issues pertaining to pistache's HTTP client labels Apr 13, 2025
@kiplingw
Copy link
Member

@vaxerski, please don't forget to bump the patch version per our documentation since you've altered the underlying implementation.

@vaxerski
Copy link
Contributor Author

uhh... where is that documentation? I've checked the website and the repo and can't find anything related to contributing guidelines.

@kiplingw
Copy link
Member

See here.

@vaxerski
Copy link
Contributor Author

ah, my bad, I got a zoomer brain. Thanks!

@vaxerski vaxerski force-pushed the drop-some-client-stuff branch from 7ec5918 to ee72e17 Compare April 13, 2025 22:28
This cumbers the availablitiy of the API and leads to bad requests that should not be bad.
@vaxerski vaxerski force-pushed the drop-some-client-stuff branch from ee72e17 to 12b862b Compare April 13, 2025 22:29
@vaxerski
Copy link
Contributor Author

done, I've also reworded the commit, I think the linter should be happy now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug http_client Issues pertaining to pistache's HTTP client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants