fix: update page titles / positions in docs #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amples to be alphabetical, move typescript to installation folder
metcoder95
reviewed
Jan 7, 2025
metcoder95
reviewed
Jan 8, 2025
…sekiguchi/piscina into Add-electron-to-Examples-in-Docs
leesoryqq
approved these changes
Jan 9, 2025
metcoder95
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went back to check to see if I could find the page on electron that I had submitted in the docs, but realized that I accidentally hadn't changed the id at the top of the page. Also saw that the sidebar positions were also out of order, so I updated them to all be alphabetical.
Lastly, Typescript setup usually is found in the installation category, so I moved it up there. There was a duplicate 'typescript.md' file in examples, so I removed that as well.