feat: use @napi-rs/nice to support Windows #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Sep 15, 2024
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Nice! This looks great, thanks for the contribution.
CI seems broken tho
Contributor
Author
|
@metcoder95 thanks, fixed |
Member
|
Now Windows does not seems to be happy |
Brooooooklyn
force-pushed
the
use-napi-rs-nice
branch
from
ec1e391 to
fdba994
Compare
Contributor
Author
|
Tests now passed on my Windows and Linux computer 🥇 |
Brooooooklyn
force-pushed
the
use-napi-rs-nice
branch
from
fdba994 to
214ff30
Compare
Member
|
Let's adjust the test to distinguish between linux and windows scenarios 👍 |
Brooooooklyn
force-pushed
the
use-napi-rs-nice
branch
4 times, most recently
from
66258cb to
c1d07d7
Compare
Brooooooklyn
force-pushed
the
use-napi-rs-nice
branch
from
c1d07d7 to
049a24d
Compare
metcoder95
approved these changes
Sep 17, 2024
metcoder95
changed the title
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v4 v4
# Navigate to the new working tree
cd .worktrees/backport-v4
# Create a new branch
git switch --create backport-655-to-v4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c56739465000f455fcf7abc2f83501054cab22a4
# Push it to GitHub
git push --set-upstream origin backport-655-to-v4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v4Then, create a pull request where the |
metcoder95
pushed a commit
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit c567394)
metcoder95
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: LongYinan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@napi-rs/niceis easier to install on CI@napi-rs/nicesupports Windows