Closed
Conversation
in strict whitelist policies we want to refuse a connection from a not allowed upstream address whether the proxy header is set or not set. Before this change if the upstream address is not allowed: 1) if the policy returns REJECT, the connection is allowed if no proxy header is sent 2) if the policy returns REQUIRE, the connection is allowed if a proxy header is set, even if the upstream address is not allowed to set it. The new REFUSE policy can be returned for not allowed addresses so that the connection is always refused.
Contributor
Author
|
I just noticed #110: if we join that PR, another way to reject a disallowed IP is to return an error from the policy function, while with this PR we can do |
Contributor
Author
|
closing, once #110 is merged we don't need a new policy we can just return an error for not allowed upstream ip addresses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in strict whitelist policies we want to refuse a connection from a not allowed upstream address whether the proxy header is set or not set.
Before this change if the upstream address is not allowed:
header is sent
header is set, even if the upstream address is not allowed to set it.
The new REFUSE policy can be returned for not allowed addresses so that the connection is always refused.