PyYAML pin fix #213
Merged
PyYAML pin fix #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM, thanks for working on this 👍 All the tests pass so we should be good to go. |
Collaborator
|
Related PR for another dependency upgrade - #211. |
Kami
approved these changes
Jan 31, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency version constraints in
setup.pyto match those inrequirements.txt.This is mostly to update to a 4.2b version of PyYAML due to CVE-2017-18342, and eventually allow updating to version 5.1+, especially because the 4.2b versions will likely be removed from PyPI once 5.1 is released (source).
Removing maximum version constraints lowers our maintenance burden.