fix: validate download path containment in runner#4417
Merged
Conversation
Resolve and contain the user-supplied filename before serving it from the runner's /files endpoint. Also raise a 404 (instead of returning None) when the downloads folder is unset, and use the resolved basename for Content-Disposition.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/files/{filename:path}download endpoint, where%2F-encoded separators bypassed Starlette's path normalisation and let an unauthenticated request read any file thepipecatprocess could access.--folderwith a 403, and returns 404 (instead of an implicitnull200) when--folderis unset.../,%2F-decoded traversal, absolute paths, and symlink escape.Testing
uv run pytest tests/test_runner_downloads.py--folder /tmp/bot_media, confirm legitimate files still download and thatcurl http://127.0.0.1:7860/files/..%2F..%2Fetc%2Fpasswdreturns 403.