Ensure to push LLMFullResponseEndFrame if the sentence is empty. #3087
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
filipi87
commented
Nov 19, 2025
Comment on lines
+367
to
+370
| # Ensure the sentence is not empty. In some cases, such as function calling, the | ||
| # LLMFullResponseEndFrame may never be pushed into the pipeline, which would | ||
| # cause issues if we proceed without "or not sentence" this check. | ||
| if self._push_text_frames or not sentence: |
Contributor
Author
There was a problem hiding this comment.
@aconchillo , @markbackman , I believe we should investigate if this is the right fix or not for this.
Contributor
Author
There was a problem hiding this comment.
Once we are happy with the fix, we can restore the changes from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure to push LLMFullResponseEndFrame if the sentence is empty.