-
Notifications
You must be signed in to change notification settings - Fork 1.4k
redesign interruption strategies #3045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aconchillo
wants to merge
9
commits into
main
Choose a base branch
from
aleix/redesign-interruption-strategies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+904
−338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
commented
Nov 12, 2025
| continue | ||
|
|
||
| silent_for = time.time() - last_update_ts | ||
| if match_endofsentence(self._text) or silent_for >= SILENCE_TIMEOUT: |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurred to me that checking for end of sentence also allowed us to use semantic to avoid false positives. This has actually worked really well. Before we were sending requests to the LLM all the time.
4e33406 to
c0dfb95
Compare
2955825 to
9add941
Compare
9add941 to
e99d79a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Introducing new interruption and speaking strategies. Interruption strategies are used to indicate when the user should interrupt the bot (e.g. using VAD events or when a user says one or more words). Speaking strategies are used to indicate when the bot should start talking (e.g. using an end-of-turn detection model, or checking how long until the last user transcription). In conversational agents these are usually referred to start/stop speaking policies or plans.
Available interruption strategies:
Avaliable speaking strategies:
To set these strategies you do it when setting up the
PipelineTask, for example:In order to use the new interruption and speaking strategies you should update to the new universal
LLMContextandLLMContextAggregatorPair.