Fix auth0 authentication #1587
Open
Fix auth0 authentication #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating Querybook with a customer’s Auth0 (Hundt Consult GmbH), I discovered that our Auth0LoginManager—which inherits from OktaLoginManager—fails to fetch the Auth0 login token correctly. That’s because:
Inherited behavior:
OktaLoginManager replaces all auth headers with NoopAuth() when requesting a token.
Auth0 requirement:
Auth0’s token endpoint requires the original auth headers to be present.
What I did:
Overrode the header-handling function in Auth0LoginManager so that it does not strip out the needed headers when calling the Auth0 token endpoint.
Impact:
This change ensures that Querybook can authenticate against Auth0 instances without losing header information.