Skip to content

fix(server): a worktree handoff on Claude or Pi completes its run and starts the continuation - #36360

Merged
juliusmarminge merged 4 commits into
mainfrom
factory/pr-35311-a1794597635
Nov 13, 2026
Merged

juliusmarminge merged 4 commits into
mainfrom
factory/pr-35311-a1794597635

fix(server): a continuation cannot message a provider-run subagent th…

36d5f86
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 13, 2026 in 2m 1s

Approved

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Worktree handoffs now persist requested continuations with the workspace binding and settle runs when the old provider session closes. The behavior remains scoped to handoffs, with existing Stop-request and provider restrictions retained.

Additional Thinking

Your Custom Policy

Applied default risk criteria. The assessed changes restore requested handoff behavior without changing product defaults and add no static-analysis suppression directives, so neither additional human-review condition applies.

Code

Queues an explicitly supplied worktree continuation within the metadata-update command rather than a later send. Session-detachment errors now identify the detached thread, allowing run finalization after a confirmed workspace move. Continuations retain provider-enabled checks, native-subagent restrictions and follow-up locking; finalization retains current-attempt and Stop-request guards. Assessment respects the five ignored files.

Review Context

Author is a repository admin and ping-devs member; no specific code ownership requirement was supplied. No unresolved review concerns or correctness findings were supplied; one thread was resolved. Two agents were skipped and UI Consistency was unknown, providing no passing-test evidence and imposing no applicable prerequisite. No blocking-severity configuration was supplied.

Verdict

The change is confined to requested workspace handoffs and optional continuations, using existing message dispatch and run-finalization mechanisms. Matching the detached thread and confirming a persisted workspace move limit the new settlement behavior; existing Stop and provider restrictions remain. No obvious material exposure or unresolved product decision requires human judgment.

Notes:
No code owners found in target merge base 9efd960


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.