Repository navigation
fix(usage): bill the Codex request a compaction's counter rewind drops #35536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rihanaws
wants to merge
6
commits into
pingdotgg:main
Choose a base branch
from
rihanaws:agent/codex-usage-counter-rewind
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+297
−17
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2f8df1a
fix(usage): bill the Codex request a compaction's counter rewind drops
rihanaws 3ef79d5
Merge remote-tracking branch 'origin/main' into agent/codex-usage-cou…
juliusmarminge e677c35
fix(usage): an ignored Codex restart replay keeps its baseline timestamp
juliusmarminge 96ad405
fix(usage): older Codex records never lower the rewind guard's timestamp
juliusmarminge 3bce42c
fix(usage): a Codex baseline of unknown age never accepts a counter r…
juliusmarminge 16fb914
fix(usage): an ignored Codex restart replay restores its baseline tim…
rihanaws File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High
t3code/apps/server/src/provider/Drivers/codexUsage.ts
Line 338 in 2a3743b
Replaying an older restart snapshot can emit the same usage again, causing duplicate billing.
rebaseCodexUsageadvanceslastCumulativeTimestampMsbefore the replay check, but the restart-replay branch restores onlylastCumulativeUsage, so the counter baseline and timestamp no longer describe the same snapshot and the next old snapshot passes the rewind guard. RestorelastCumulativeTimestampMsalongside the counters when ignoring the replay.🤖 Copy this AI Prompt to have your agent fix this: