You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: AGENTS.md and the FAQ list Pi, Muse Code, Kiro, and fx - #33906
T3 Code registers ten named agent providers plus ACP Registry, but AGENTS.md's intro and its Providers bullet (which tells agents to decide per adapter) leave out Pi, Muse Code, fx and, in the bullet, ACP Registry, and the FAQ's "Bring your own" line leaves out Kiro and fx.
Change
I added the missing names to those three lines, in the order main's README has used since #35170, so all three lists agree. ACP Registry stays out of the intro and the FAQ, which name agents a user brings. All eleven are in BUILT_IN_DRIVERS (apps/server/src/provider/builtInDrivers.ts).
Scope
Docs only, not a bug fix. On closing #28733, juliusmarminge wrote: "If the AGENTS.md and FAQ updates still matter, a smaller follow-up for those would be welcome."
Verification
No test applies and no screen changes. vp run check:changed on 32af39ca85: format passes. Before (-, main f419698aea) and after (+), from git diff -U0 f419698aea 32af39ca85 -- AGENTS.md docs/user/faq.md:
-T3 Code is a minimal GUI for coding agents. A Node WebSocket server wraps provider CLIs and agents (Codex, Claude Code, Cursor, Grok, OpenCode, Antigravity, Kiro) and serves web, desktop, and mobile clients.+T3 Code is a minimal GUI for coding agents. A Node WebSocket server wraps provider CLIs and agents (Claude Code, Codex, Cursor, OpenCode, Grok, Antigravity, Kiro, Pi, Muse Code, fx) and serves web, desktop, and mobile clients.-- **Providers.** Codex, Claude, Cursor, Grok, OpenCode, Antigravity, and Kiro each have an adapter. Provider-shaped features need a decision per adapter, even if the decision is "not supported here".+- **Providers.** Claude, Codex, Cursor, OpenCode, Grok, Antigravity, Kiro, Pi, Muse Code, fx, and ACP Registry each have an adapter. Provider-shaped features need a decision per adapter, even if the decision is "not supported here".-Bring your own: Claude Code, Codex, Cursor, Grok Build, OpenCode, Google Antigravity, Pi, or Muse Code. [Provider setup](./install.md#providers)+Bring your own: Claude Code, Codex, Cursor, OpenCode, Grok Build, Google Antigravity, Kiro, Pi, Muse Code, or fx. [Provider setup](./install.md#providers)
evals/test-signal reads this checkout's AGENTS.md. I ran it on main f419698aea and on 32af39ca85 with default models and samples, with no errors:
Model
Bad caught, guards clean (main / this PR)
Tokens (main / this PR)
gpt-6.1-terra
6/6, 3/4 / 6/6, 3/4
226,146 / 206,033
gpt-6-luna
6/6, 2/4 / 5/6, 2/4
371,640 / 353,923
The one difference, gpt-6-luna on new-it-for-a-table-row, passed 2 of 6 samples on each side when I reran that case alone. Both models fail the deadlock-race-fix guard on both sides, and gpt-6-luna also fails clone-retry-fix. No eval reads the FAQ.
Provider table and name check
I checked each name against its driver's displayName and client label on main f419698aea. Pi, Muse Code, fx and ACP Registry each have their own adapter (packages/provider-*/src/server/adapter.ts), so "each have an adapter" stays true.
Macroscope's review found this PR approvable — Updates the provider lists in contributor guidance and the user FAQ. The changes are documentation-only and do not alter product defaults or runtime behavior.
You can add or adjust custom eligibility rules. Learn more.
Reviewing files that changed from the base of the PR and between 32af39c and c28b7f0.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
Provider lists in AGENTS.md and the user FAQ now include additional providers. The repository guidance adds Pi, Muse Code, fx, and ACP Registry. The FAQ adds Grok Build and fx to its “Bring your own” list.
AGENTS.md adds Pi, Muse Code, and fx to its description, and adds Pi, Muse Code, fx, and ACP Registry to its checklist. The FAQ adds Grok Build and fx to its “Bring your own” list.
This is a documentation-only update that adds missing provider names to the repository guidance and the user FAQ. It does not change product behavior, and no merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the three edited lines and the providers added to them, so it matches the changeset. It is clear and specific. It does not mention the Kiro or ACP Registry details in full, which is ac…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states the problem, the change, the scope, and the verification in a clear way. It names the three docs lines that changed and explains why ACP Registry is excluded from the intro and …
Full details: Title check
Explanation
The title names the three edited lines and the providers added to them, so it matches the changeset. It is clear and specific. It does not mention the Kiro or ACP Registry details in full, which is acceptable.
Full details: Description check
Explanation
The description states the problem, the change, the scope, and the verification in a clear way. It names the three docs lines that changed and explains why ACP Registry is excluded from the intro and FAQ. It links the related PR #28733 and gives a provider-by-file table that supports the name choices. The verification includes a format check, a before/after diff, and eval results. The template's Problem, Change, Scope, and Verification sections are all present and filled in. The closing line names the model and harness, as the template asks. Minor gaps: the Problem section does not state a reproduction step, which is normal for a docs-only change, and the description does not link an issue for the scope, though it does cite a maintainer request. Overall the description is mostly complete.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
The automated pipeline stopped on this pull request and will not merge it:
the proof was not accepted:
head-intro.png vs base-intro.png: besides the edited provider sentence, head shows a vertical scrollbar thumb at the right edge of the document viewer (about CSS x=995, y=65-140) that base does not, and base shows the file-explorer toggle (top-right toolbar) with a filled hover/pressed background that head lacks; the pair differs in UI state the docs-only change does not touch.
head-checklist.png vs base-checklist.png: same mismatch. Head shows a scrollbar thumb mid-right that base does not, and base's file-explorer toggle has a hover/pressed background that head lacks. The before/after were not captured in the same UI state.
The capture method's 500 ms stability check cannot catch hover or overlay-scrollbar differences between the two sides; matching pointer position and scroll-idle state across sides would have.
I did not rebuild an after capture from seed.py and reproduction.md.
It stays open for a person to finish or close.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Problem
T3 Code registers ten named agent providers plus ACP Registry, but AGENTS.md's intro and its Providers bullet (which tells agents to decide per adapter) leave out Pi, Muse Code, fx and, in the bullet, ACP Registry, and the FAQ's "Bring your own" line leaves out Kiro and fx.
Change
I added the missing names to those three lines, in the order main's README has used since #35170, so all three lists agree. ACP Registry stays out of the intro and the FAQ, which name agents a user brings. All eleven are in
BUILT_IN_DRIVERS(apps/server/src/provider/builtInDrivers.ts).Scope
Docs only, not a bug fix. On closing #28733, juliusmarminge wrote: "If the AGENTS.md and FAQ updates still matter, a smaller follow-up for those would be welcome."
Verification
No test applies and no screen changes.
vp run check:changedon32af39ca85: format passes. Before (-, mainf419698aea) and after (+), fromgit diff -U0 f419698aea 32af39ca85 -- AGENTS.md docs/user/faq.md:evals/test-signalreads this checkout's AGENTS.md. I ran it on mainf419698aeaand on32af39ca85with default models and samples, with no errors:The one difference, gpt-6-luna on
new-it-for-a-table-row, passed 2 of 6 samples on each side when I reran that case alone. Both models fail thedeadlock-race-fixguard on both sides, and gpt-6-luna also failsclone-retry-fix. No eval reads the FAQ.Provider table and name check
I checked each name against its driver's
displayNameand clientlabelon mainf419698aea. Pi, Muse Code, fx and ACP Registry each have their own adapter (packages/provider-*/src/server/adapter.ts), so "each have an adapter" stays true.apps/server/src/provider/Drivers/CodexDriver.tsapps/server/src/provider/Drivers/ClaudeDriver.tspackages/provider-cursor/src/server/driver.tspackages/provider-grok/src/server/driver.tspackages/provider-opencode/src/server/driver.tsapps/server/src/provider/Drivers/AntigravityDriver.tspackages/provider-kiro/src/server/driver.tspackages/provider-pi/src/server/driver.tspackages/provider-muse/src/server/driver.tspackages/provider-fx/src/server/driver.tspackages/provider-acp-registry/src/server/driver.tsGenerated with Claude Opus 5.5 in T3 Code Nightly