You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): Revoke others asks before signing out every other paired device - #32734
In Settings → Sharing & access, one click on Revoke others signs out every other paired client (phones, other browsers, linked machines). There is no confirmation and no undo, and each one then needs a new pairing link. The same page already asks before removing a saved environment.
To reproduce on main: pair other clients, open Settings → Sharing & access and click Revoke others. "Revoked N clients" appears with no dialog.
Change
The Revoke others button now calls requestConfirmDialog with the destructive variant and calls onRevokeOtherClients only on true. This is the same call the page uses for removing a saved environment. Cancel or dismiss does nothing; Confirm revokes as before.
The confirm sits in AuthorizedClientsHeaderAction, the button's only render site, so the existing browser test covers it. handleRevokeOtherDesktopClients is unchanged and still checks the write scope when it runs.
The per-client Revoke and the pairing-link revoke are unchanged.
Surfaces: web and desktop render this component, so both get the confirm. Mobile has no Revoke others control.
Scope and approval
This uses the very small, focused fix exception: one click irreversibly signs out every other device without asking, while the same page confirms its other destructive actions. The fix adds one existing confirm call to one button. I found no issue or PR that asks for or rejects this. #31733 edits nearby code; git merge-tree against its head is clean.
Verification
Two rows added to the existing AuthorizedClientsSettings.browser.test.tsx: with the confirm resolving false, onRevokeOtherClients is not called; with true, it is called once.
cd apps/web && vp test run --project browser src/components/settings/AuthorizedClientsSettings.browser.test.tsx
With main's component (a9e709f15): Tests 2 failed | 2 passed (4), expected "vi.fn()" to be called once, but got 0 times. The confirm is never asked.
This branch: Tests 4 passed (4).
vp run check:changed a9e709f15: format, lint, knip, typecheck, test and React Compiler pass.
Captures use local dev servers with three test sessions issued by the server's CLI and named "Phone", "Tablet" and "Laptop browser" (they list as Bot), not real paired devices. Before: this branch with AuthorizedClientsSettings.tsx restored from maina9e709f15 (the commit's only other file is its test). After: d7ad5fde96, whose tree is identical to this head 5bc91a0dc3 (git diff between them prints nothing).
Web (clicked in the T3 Browser panel):
Before: four authorized clients.
Before: one click on Revoke others removes the other three with no dialog.
After: Revoke others opens a confirmation first.
After: Cancel closes the dialog and all four clients stay (same screen as the first image, from a separate run).
After: Confirm revokes the other three.
Desktop (Electron dev client, vp run dev:desktop on Linux, clicks sent through the debugging port):
Before: four authorized clients.
Before: one click removes the other three with no dialog.
After: Revoke others opens a confirmation first.
After: Cancel keeps all four clients.
After: Confirm revokes the other three.
Not checked: a packaged desktop build, and macOS or Windows desktop. A write-only grant (no list shown) is covered by the browser test (clientSessions={null}) but not captured.
Macroscope's review found this PR approvable — Adds confirmation before revoking other paired clients, warning that reconnecting requires a new pairing link. The existing revocation action remains unchanged and runs only after explicit confirmation.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
The “Revoke others” action now asks for destructive confirmation before revoking other paired clients. The callback runs only when confirmation is accepted. Tests cover both confirmation outcomes.
Changes: Client revocation confirmation
Layer / File(s)
Summary
Confirmation and revocation behavior apps/web/src/components/settings/AuthorizedClientsSettings.tsx, apps/web/src/components/settings/AuthorizedClientsSettings.browser.test.tsx
The action requests confirmation before calling the revocation callback. Tests verify that declining does not call the callback and confirming calls it once.
Bulk revocation now requires confirmation. No merge-blocking issue was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: Revoke others now asks for confirmation before it signs out every other paired device. It is a conventional commit title in plain language, matching the change in Auth…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description follows the repository template closely. It has Problem, Change, Scope and approval, and Verification sections. The Problem section gives the expected behavior and reproduction steps. …
Full details: Title check
Explanation
The title names the main change: Revoke others now asks for confirmation before it signs out every other paired device. It is a conventional commit title in plain language, matching the change in AuthorizedClientsHeaderAction and the browser test updates.
Full details: Description check
Explanation
The description follows the repository template closely. It has Problem, Change, Scope and approval, and Verification sections. The Problem section gives the expected behavior and reproduction steps. The Change section explains the confirm call and why it sits in the header action. The Scope section invokes the very small focused fix exception and explains why it qualifies. The Verification section lists specific commands, before/after test results, and check results. It includes before/after screenshots for web and desktop, and it states what was not checked. The model and harness are named at the end, as the template requires. The title follows the conventional commit style. Minor gaps: the title is not shown in the description body, and the screenshots are linked from a gist rather than uploaded as PR-only assets, which the template permits. Those gaps are non-critical.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
verified unchanged head 5bc91a0dc3a94cf2b6dee838d842cdcb4e19a49b on this linux boat vm using the real dev server, repo Playwright, and /usr/bin/google-chrome. no mocks, fixtures, or demo data. projects, threads, pairing credentials, and sessions were created through the app. real Codex gpt-6.1-sol turns completed on both revisions.
before: checked out github/main at 934c7f8d8e7a012aa55be9c0b17498979040fe02 in a separate worktree, ran vp i, and reproduced one-click bulk revocation with two real browser profiles. no confirmation appeared; the other browser required pairing after reload.
after: stopped main, checked out the exact pr head, ran vp i, and started vp run dev --home-dir /home/user/t3code/.t3 in the background. settings → sharing & access → revoke others opened the destructive confirmation.
cancel and escape left both clients authorized. after cancel, the other browser remained authenticated across reload.
confirm revoked the other browser, which required pairing after reload. the initiating browser stayed authenticated and completed another real Codex turn afterward.
neighboring behavior: a fresh pairing token reconnected the revoked browser; individual revoke still signed out that browser.
Blacksmith: cd apps/web && vp test run --project browser src/components/settings/AuthorizedClientsSettings.browser.test.tsx passed all 4 tests after installing the missing Chromium on the worker. github checks currently have 21 passes, 8 skips, and no failures or pending checks. skips are not verification.
before: one click on main revoked the other browser without a dialog.
after: the same two-browser scenario requires confirmation.
interaction recording, slowed for readability and shown as an animated gif for github. inspected the captures and checked uploaded video playback and seeking.
runtime transcript:
PASS cancel: both clients remain, dialog closed
PASS escape: both clients remain
PASS confirm: 1 other client revoked, current client retained
PASS revoked browser: reload requires pairing
PASS new pairing token reconnects revoked browser
PASS cancel preserves real browser authentication after reload
PASS individual Revoke still signs out target browser
PASS current client completed another real gpt-6.1-sol turn after revocation
Not verified
native desktop/Electron, packaged macOS/Windows clients, native iOS/Android, physical devices, remote/relay/tunnel connections, and restricted or write-only grants were not exercised. mobile has no bulk-revoke control in this change. missing confirmation-host teardown and rapid repeated clicks were not exercised in the running app. no code changes were needed; no commits or pushes were made.
Thanks @maria-rcks for testing this end to end with two real browser profiles. Your run confirms the change on the unchanged head: on main, one click signed out the other browser, and on this head, Revoke others opens the confirmation first. Cancel and Escape keep both browsers signed in across a reload, and Confirm signs out only the other browser while the current one keeps working. A fresh pairing token still reconnects the signed-out browser, and the single-device Revoke still works. Noted that desktop, mobile, remote connections, a missing confirmation host and rapid repeated clicks are still untested in a running app. The browser test covers Cancel and Confirm only.
Closing this: it is not a bug fix, and this repository now takes only bug fixes from outside contributors. The branch stays on my fork if it is useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Problem
In Settings → Sharing & access, one click on Revoke others signs out every other paired client (phones, other browsers, linked machines). There is no confirmation and no undo, and each one then needs a new pairing link. The same page already asks before removing a saved environment.
To reproduce on
main: pair other clients, open Settings → Sharing & access and click Revoke others. "Revoked N clients" appears with no dialog.Change
The Revoke others button now calls
requestConfirmDialogwith the destructive variant and callsonRevokeOtherClientsonly ontrue. This is the same call the page uses for removing a saved environment. Cancel or dismiss does nothing; Confirm revokes as before.The confirm sits in
AuthorizedClientsHeaderAction, the button's only render site, so the existing browser test covers it.handleRevokeOtherDesktopClientsis unchanged and still checks the write scope when it runs.Left as is on purpose:
canRevokeOtherClients(null)staystrue, as feat(auth): separate environment administration permissions #9786 decided, so write-only grants keep their bulk revoke. They now get the confirm too, which matters because they cannot see the list.Surfaces: web and desktop render this component, so both get the confirm. Mobile has no Revoke others control.
Scope and approval
This uses the very small, focused fix exception: one click irreversibly signs out every other device without asking, while the same page confirms its other destructive actions. The fix adds one existing confirm call to one button. I found no issue or PR that asks for or rejects this. #31733 edits nearby code;
git merge-treeagainst its head is clean.Verification
Two rows added to the existing
AuthorizedClientsSettings.browser.test.tsx: with the confirm resolvingfalse,onRevokeOtherClientsis not called; withtrue, it is called once.main's component (a9e709f15):Tests 2 failed | 2 passed (4),expected "vi.fn()" to be called once, but got 0 times. The confirm is never asked.Tests 4 passed (4).vp run check:changed a9e709f15: format, lint, knip, typecheck, test and React Compiler pass.Captures use local dev servers with three test sessions issued by the server's CLI and named "Phone", "Tablet" and "Laptop browser" (they list as Bot), not real paired devices. Before: this branch with
AuthorizedClientsSettings.tsxrestored frommaina9e709f15(the commit's only other file is its test). After:d7ad5fde96, whose tree is identical to this head5bc91a0dc3(git diffbetween them prints nothing).Web (clicked in the T3 Browser panel):
Before: four authorized clients.
Before: one click on Revoke others removes the other three with no dialog.
After: Revoke others opens a confirmation first.
After: Cancel closes the dialog and all four clients stay (same screen as the first image, from a separate run).
After: Confirm revokes the other three.
Desktop (Electron dev client,
vp run dev:desktopon Linux, clicks sent through the debugging port):Before: four authorized clients.
Before: one click removes the other three with no dialog.
After: Revoke others opens a confirmation first.
After: Cancel keeps all four clients.
After: Confirm revokes the other three.
Not checked: a packaged desktop build, and macOS or Windows desktop. A write-only grant (no list shown) is covered by the browser test (
clientSessions={null}) but not captured.Generated with Claude Opus 5.5 in T3 Code Nightly