Skip to content

Guard release workflow jobs from upstream failures - #2146

Merged
juliusmarminge merged 1 commit into
mainfrom
feature/guard-release-jobs
Apr 17, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
feature/guard-release-jobs

Guard release jobs from failing workflows

510350a
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Apr 17, 2026 in 5m 30s

Needs review (click on check for more details)

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Unresolved review comments identify a bug: the new guard conditions allow jobs to run when upstream jobs are skipped (not just failed), which could cause broken releases on scheduled runs. The suggested fix is to add && needs.preflight.result == 'success' to each condition.

Notes:
No code owners found in target merge base 9c64f12

Correctness
1 blocking correctness issue found