Skip to content

*: fix security issues#1731

Open
mornyx wants to merge 2 commits intomasterfrom
mornyx/sec
Open

*: fix security issues#1731
mornyx wants to merge 2 commits intomasterfrom
mornyx/sec

Conversation

@mornyx
Copy link
Collaborator

@mornyx mornyx commented Sep 18, 2024

This PR fixes some security issues.

  • Use of inherently dangerous function in pkg/apiserver/logsearch/task.go.
  • Potential SQL injection in pkg/apiserver/statement/queries.go. (In reality, only SQL digests are concatenated, so this won’t happen, but it’s there to prevent “potential changes”.)
  • External service interaction via DNS in pkg/apiserver/logsearch.
  • Lack of rate limiting on unauthed API /api/user/login.

Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from Renkai September 18, 2024 15:02
@ti-chi-bot ti-chi-bot bot added the size/L label Sep 18, 2024
Signed-off-by: mornyx <mornyx.z@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant