feat: v2 hierarchical categories #205
Conversation
wayfarer3130
force-pushed
the
feat/v2-hierarchical-categories
branch
from
7a8e05b to
6bac8ea
Compare
lib/loglevel.js
Outdated
| return defaultLevel; | ||
| } else { | ||
| return inheritedLevel; | ||
| if (userLevel !== null) { |
There was a problem hiding this comment.
This fixes a bug where user level 0 wasn't applying.
lib/loglevel.js
Outdated
| * @type {number} | ||
| */ | ||
| var inheritedLevel; | ||
| var inheritedLevel = null; |
There was a problem hiding this comment.
These null changes fix a bug causing the levels to not apply correctly.
…to feat/v2-hierarchical-categories
|
@pimterry - I added the hierarchical loggers and the |
pimterry
left a comment
pimterry
left a comment
There was a problem hiding this comment.
I've added quite a few comments. This is a great start but there's a few ways we can simplify this. I've tried to cover the main points here so you get an idea - the main thing is that I don't think we need also the extra fields and edge cases.
|
@pimterry @Mr0grog
It needs docs updated, but I'm not going to complete that until the code is approved, then I will change just the docs. |
pimterry
left a comment
pimterry
left a comment
There was a problem hiding this comment.
Nice work @wayfarer3130! I like the approach. A couple more comments but just on small details now, I think this is nearly there.
There are other details we could tweak, but we can fix those up later (I agree the indentation is currently a mess for example, we should standardize on something there - personally I'd lean to 4 spaces everywhere but whatever people prefer).
This is mergeable though imo once the two loggers API details here are covered and the exports changes are pulled out.
|
Made the changes you requested |
|
Nice stuff, thanks @wayfarer3130! Merged 👍 |
4 participants
Add hierarchical categories in loglevel v2