-
Notifications
You must be signed in to change notification settings - Fork 292
chore: support node.js >=6, remove safe-buffer #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Pull Request Test Coverage Report for Build 17057459238Details
💛 - Coveralls |
Member
Author
blakeembrey
approved these changes
Aug 19, 2025
Member
blakeembrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Merged
bjohansebas
added a commit
that referenced
this pull request
Aug 19, 2025
This reverts commit 4c2842a.
bjohansebas
added a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are preparing version 0.7.0 (#334), this is technically a new major release, so we can remove some of the old Node.js support. I didn’t want to be too drastic since version 1 is the one planned to remove most of the legacy code and obviously the old support, to align it with Express support.
Dropping support for Node < 6 helps remove safe-buffer (Since after Node 6 this package is no longer needed to cover the purpose of safe-buffer.)(I still need to check if webpack still compiles this package properly, let’s wait and see what comes out in CI).
I could update the linter rule to already use let/const, but I’d rather do that after the release to properly verify the behavior
closes #322
cc: @blakeembrey