Skip to content

Conversation

@bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Aug 19, 2025

Since we are preparing version 0.7.0 (#334), this is technically a new major release, so we can remove some of the old Node.js support. I didn’t want to be too drastic since version 1 is the one planned to remove most of the legacy code and obviously the old support, to align it with Express support.

Dropping support for Node < 6 helps remove safe-buffer (Since after Node 6 this package is no longer needed to cover the purpose of safe-buffer.)(I still need to check if webpack still compiles this package properly, let’s wait and see what comes out in CI).

I could update the linter rule to already use let/const, but I’d rather do that after the release to properly verify the behavior

closes #322

cc: @blakeembrey

@coveralls
Copy link

coveralls commented Aug 19, 2025

Pull Request Test Coverage Report for Build 17057459238

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 93.831%

Totals Coverage Status
Change from base Build 17015959667: -0.006%
Covered Lines: 943
Relevant Lines: 1005

💛 - Coveralls

@bjohansebas
Copy link
Member Author

It slightly reduces the webpack build.

Master branch:
imagen
This pr:
imagen

Copy link
Member

@blakeembrey blakeembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas bjohansebas merged commit 4c2842a into master Aug 19, 2025
48 checks passed
@bjohansebas bjohansebas deleted the node-6 branch August 19, 2025 02:06
@bjohansebas bjohansebas mentioned this pull request Aug 19, 2025
bjohansebas added a commit that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message:Cannot find module 'buffer' imported from '&safer-buffer/safer&2.1.2'.

3 participants