Skip to content

Conversation

@bjohansebas
Copy link
Member

Neostandard is being adopted as the linter. In Express we currently use Standard, but we’re planning to change it, though we don’t yet know which one. Anyway, there’s no issue in adopting this linter :), and it will also help us run type tests for this package, which I’ll try to add in a following PR after this one is merged

Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
@coveralls
Copy link

coveralls commented Aug 17, 2025

Pull Request Test Coverage Report for Build 17015694733

Details

  • 934 of 996 (93.78%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 93.837%

Changes Missing Coverage Covered Lines Changed/Added Lines %
encodings/sbcs-codec.js 34 36 94.44%
encodings/utf16.js 87 89 97.75%
lib/streams.js 51 55 92.73%
encodings/internal.js 89 96 92.71%
lib/index.js 75 82 91.46%
encodings/dbcs-codec.js 285 303 94.06%
encodings/utf32.js 130 152 85.53%
Totals Coverage Status
Change from base Build 17012299652: 1.1%
Covered Lines: 944
Relevant Lines: 1006

💛 - Coveralls

@bjohansebas
Copy link
Member Author

It's funny that the build got a bit smaller, even though no logic changes were made, it was only changes that eslint did

Master:

imagen

This pr:
imagen

Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas bjohansebas requested a review from Copilot August 17, 2025 02:34

This comment was marked as off-topic.

@bjohansebas
Copy link
Member Author

I've reviewed the changes several times, it only removes spaces, so it reduces lines of code, and that's why the build gets smaller.

@bjohansebas bjohansebas merged commit 2a31790 into master Aug 17, 2025
36 checks passed
@bjohansebas bjohansebas deleted the lint branch August 17, 2025 02:54
@bjohansebas
Copy link
Member Author

I added a .git-blame-ignore-revs so the blame doesn’t get messed up with these changes
https://github.com/ashtuchkin/iconv-lite/blob/master/.git-blame-ignore-revs

@bjohansebas bjohansebas mentioned this pull request Aug 18, 2025
@voxpelli
Copy link

FYI: We are working on merging neostandard back into standard, so soon you might have an automatic solution for express ;P

@bjohansebas
Copy link
Member Author

Ohhh, wow, I’m glad to hear that, that would be super cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants