chore: update performance tests to use bench-node for benchmarking #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Beltran <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
Using GitHub runners (they’re not reliable because they usually share resources across multiple workflows, so it’s not a clean machine), the performance would look something like this: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies our benchmark tests against node-iconv, using bench-node, which is a great tool for this kind of work.
It doesn’t matter that the tests can’t be run on Node 0.12 or older versions, since it’s already complicated to run node-iconv on those versions nowadays.
It would be great to be able to run the tests again on a new machine to see how much things have changed over the years in Node.js, but for that we’d need a clean machine, and we don’t have those resources available.