Fix build without mbedtls [v2]#2796
Merged
DL6ER merged 1 commit intopi-hole:developmentfrom Mar 4, 2026
Merged
Conversation
Commit 3b45213 (Implement automatic TLS/SSL certificate renewals) [1] introduced functionality that requires mbedtls, but mbedtls is an optional dependency. This leads to the following compilation error: pihole-ftl-6.5/src/webserver/webserver.c:36:10: fatal error: mbedtls/ssl_ciphersuites.h: No such file or directory 36 | #include <mbedtls/ssl_ciphersuites.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. Use the HAVE_MBEDTLS preprocessor symbol to assert that certificate related code is only included if mbedtls is present in the build. [1] pi-hole@3b45213 Signed-off-by: Andreas Ziegler <15275159+aeolio@users.noreply.github.com>
DL6ER
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Commit 3b45213 (Implement automatic TLS/SSL certificate renewals) introduced functionality that requires mbedtls, but mbedtls is an optional dependency. This leads to the following compilation error:
How does this PR accomplish the above?:
Use the HAVE_MBEDTLS preprocessor symbol to assert that certificate related code is only included if mbedtls is present in the build.
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)