Skip to content

Fix build without mbedtls [v2]#2796

Merged
DL6ER merged 1 commit intopi-hole:developmentfrom
aeolio:gravity
Mar 4, 2026
Merged

Fix build without mbedtls [v2]#2796
DL6ER merged 1 commit intopi-hole:developmentfrom
aeolio:gravity

Conversation

@aeolio
Copy link

@aeolio aeolio commented Mar 4, 2026

What does this PR aim to accomplish?:

Commit 3b45213 (Implement automatic TLS/SSL certificate renewals) introduced functionality that requires mbedtls, but mbedtls is an optional dependency. This leads to the following compilation error:

pihole-ftl-6.5/src/webserver/webserver.c:36:10: fatal error: mbedtls/ssl_ciphersuites.h: No such file or directory
   36 | #include <mbedtls/ssl_ciphersuites.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

How does this PR accomplish the above?:

Use the HAVE_MBEDTLS preprocessor symbol to assert that certificate related code is only included if mbedtls is present in the build.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • [x ] I have read the above and my PR is ready for review. Check this box to confirm

Commit 3b45213 (Implement automatic TLS/SSL certificate renewals) [1]
introduced functionality that requires mbedtls, but mbedtls is an
optional dependency. This leads to the following compilation error:

pihole-ftl-6.5/src/webserver/webserver.c:36:10: fatal error: mbedtls/ssl_ciphersuites.h: No such file or directory
   36 | #include <mbedtls/ssl_ciphersuites.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Use the HAVE_MBEDTLS preprocessor symbol to assert that certificate related
code is only included if mbedtls is present in the build.

[1] pi-hole@3b45213

Signed-off-by: Andreas Ziegler <15275159+aeolio@users.noreply.github.com>
@aeolio aeolio requested a review from a team as a code owner March 4, 2026 16:02
@rdwebdesign rdwebdesign requested a review from DL6ER March 4, 2026 18:17
@DL6ER DL6ER enabled auto-merge March 4, 2026 19:16
@DL6ER DL6ER merged commit 149a879 into pi-hole:development Mar 4, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants