Disable flush_logs endpoint inside docker containers #2656
+39
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
The flush process needs a FTL restart, but this is not possible inside docker containers (not enough permissions). Currently, if the API endpoint is called inside a container, it returns "success" and FTL logs success messages, but in reality FTL is never restarted and the process is not correctly completed.
This PR effectively disables the
flush_logsendpoint when FTL is inside a container. Inside containers the API will respond with403 forbidden.This is related to: pi-hole/pi-hole#6391
How does this PR accomplish the above?
FTL checks if it is running inside docker and, if so, returns a 403 error message.
By submitting this pull request, I confirm the following:
git rebase)