Skip to content

Conversation

@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jul 4, 2025

Languages included:

  • json
  • plaintext

I'm not sure which languages are used. I mainly see JSON, one instance of HTML and one plaintext.

The HTML and plaintext snippets are not highlighted on develop nor here for me, though so this means it's another issue.

Note that this fixes a console error regarding exports which makes me wonder how this even worked before... Is this even used?

Uncaught SyntaxError: export declarations may only appear at top level of a module

I only tested this by spinning a local server in the docs path.

EDIT: I added a second patch which remove highlight.js. If everything looks good let me know so that I squash the patches.


Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

XhmikosR added 2 commits July 4, 2025 19:44
Languages included:

* json
* plaintext

Signed-off-by: XhmikosR <[email protected]>
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jul 8, 2025

@DL6ER can you confirm if highlight.js is really needed?

It's one less external dependency if not, otherwise the first patch does fix highlight.js loading, which is another reason I suspect that highlight.js is unused since it wasn't being loaded before this patch due to the SyntaxError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant