Demo PR

[RayStick]

Demo PR to show how the main reviewer checklist can work

• Rachael opens a PR, so is assigned to this PR by default by the Auto Author Assign GH action (but this does not trigger the Main Reviewer Checklist which is good)
• Rachael puts Stef as a reviewer, and as an assignee (to signify the main reviewer role)
• Stef as a new assignee then triggers the GitHub action Main Reviewer Checklist which posts a comment

---

Unintended behaviour - but maybe we are okay with it?

1. I also assigned Mary, and it directed the review comment to her as well
2. I then deleted Stef as an assignee, but the comment remains

Both of these things are to be expected considering the yml workflow but do we want to update the workflow to try to stop these types of things? Or just assume that the PR author will only put one person in this slot.

[smoia]

This is awesome!
I think the point that stopped me was how to trigger the main reviewer checklist only once to the first person (self-)assigned to review, and then a more generic reviewer checklist to anyone else. That'd be a great solution IMHO, but IDK how to do it.

[RayStick]

This is awesome!

Thanks =D

I think the point that stopped me was how to trigger the main reviewer checklist only once to the first person (self-)assigned to review, and then a more generic reviewer checklist to anyone else. That'd be a great solution IMHO, but IDK how to do it.

So just so I understand, the ideal scenario would be:

1. Send a checklist (like the one above) to the main reviewer (main reviewer is the person added to the assignee slot and the reviewer slot)
2. Send a checklist (much simpler than the one above) to all other reviewers (added to reviewer slot only)

If yes, I can give that a go

[smoia]

That could be good solution! Even better if the first person signing up as reviewer is also automatically assigned and prompted this message, vs any other reviewer that comes after.

[github-actions]

Hello @!

You've been assigned to this PR, which means that you've been nominated as reviewer! You are a supporting reviewer, not the main reviewer - the main reviewer has more responsibilities than you (lucky them) but your review is still important.

If you have any doubt, check this section on reviewing

Checklist

• one
• two
• three

Thank you!

[github-actions]

Hello @smoia!

You've been assigned to this PR, which means that you've been nominated Main Reviewer! Lucky you!

As a Main Reviewer, you are slightly more responsible for the quality of this PR than your fellow Reviewers. If you have any doubt, check this section on reviewing and this section on being the Main Reviewer of the documents.

Before merging this PR, please check that:

• The PR passes all the CircleCI/Azure tests.
• The content respects the Style Guide.
• If the PR contains documentation, your local build is right.
• The PR and the reviews are harmonious with the rest of the repository, especially that they don't introduce repetitions
• The title of the PR is clear enough to describe a release content.
• The labels are correct - and they will (or won't) trigger the correct auto release.
• The PR received the amount of approvals necessaries to be merged.

If the PR contains code changes:

• Content and changes are adequately documented in the docstrings.
• User documentation is being updated accordingly - or a related issue has been opened.
• The adequate tests have been added/updated - or a related issue has been opened if coverage doesn't drop below 90%.

After you merged this PR, please check that:

• The Author(s) and Reviewers contributions have been updated in the README.
• The updates (in code, tests and documentation) have appened correctly.
• If they had to, the tag was created, the release was cut, and the pypi version got updated.

Thank you!

[RayStick]

@smoia and @m-miedema feel free to unsubscribe from notifications whilst I am testing things, sorry!