Upgrade baseimage to Ubuntu 24.04#639
Merged
Merged
Conversation
The config file is taken from the syslog-ng upstream repository. It got added for the syslog-ng 4.2.0 release and remained unchanged since then (as of April 2024). https://github.com/syslog-ng/syslog-ng/blob/syslog-ng-4.2.0/lib/multi-line/smart-multi-line.fsm
Contributor
Author
|
Ubuntu 24.04 is expected to be released on Thursday, April 25th 2024. I've tested with the beta release, but would recommend to wait the remaining five days before merging. Hence, I've set this PR to draft. Nevertheless, I would be happy to start reviewing already and to receive feedback. As soon as Ubuntu 24.04 is finally released, I will mark this PR as ready for review. |
Contributor
Author
|
Ubuntu 24.04 has been released today. Hence, this PR is now ready. |
samip5
approved these changes
Apr 26, 2024
Contributor
samip5
left a comment
There was a problem hiding this comment.
I don't see anything particularly wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR upgrades the baseimage and dependent files for Ubuntu 24.04. As part of this upgrade, config files for syslog-ng were updated, too.
Here are some thoughts on the dedicated commits:
Vagrantfile andMakefile. TheVagrantfile seems to be a no-brainer, and a newnoble64box is already available. TheMakefileshould work again as soon as a new release was drafted.syslog-ng.confchange was required due to the following warning and the newer version 4.3 shipping with Ubuntu 24.04:smart-multi-line.fsmis optional. I did so to resolve another warning:Benefits
A newer Ubuntu version is available and warnings normally issued with the upgrade are resolved.
Possible drawbacks
The new Ubuntu version and all the package version changes might include breaking changes. While I tried to test the changes and thereby discovered the syslog-ng changes, I cannot rule out that further changes are necessary.
Applicable issues
None
Additional information
Reviewing commit-by-commit is recommended.