Remove riscv64 from build platforms#633
Merged
Merged
Conversation
The docker image `ubuntu:22.04` is not available for `riscv64`, which limits options for providing support for it here.
samip5
approved these changes
Feb 16, 2024
Contributor
samip5
left a comment
There was a problem hiding this comment.
This breaks riscv64, but the newer ubuntu is not available for it so YOLO.
Contributor
|
You are the ones in charge of the project, no questions asked. https://ubuntu.com/download/risc-v For risc-v docker Ubuntu images, I use https://hub.docker.com/r/riscv64/ubuntu at the moment. |
Contributor
Author
|
I've opened #634 with an attempt to bring back support for riscv64. Cross-posting:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
I'm hoping this will unblock the release of jammy-1.0.2.
The docker image
ubuntu:22.04is not available forriscv64, which limits options for providing support for it here.Benefits
Unblocks release?
Possible drawbacks
cc @olof-nord who added this in 2021 via #604, back then the release was focal.
Applicable issues
#632
Additional information