Add compatibility for PHP 8.5 #1500
Conversation
|
@andypost seems like 8.5 should be added to Prophecy first 🤔 |
|
yes, related phpspec/prophecy#656 |
| - PHP 8.4 compatibility [@jrfnl](https://github.com/jrfnl) [@andypost](https://github.com/andypost) | ||
| - PHP 8.4 compatibility [@jrfnl](https://github.com/jrfnl) [@andypost](https://github.com/andypost) | ||
|
|
||
| ## [8.1.0](https://github.com/phpspec/phpspec/compare/8.0.0...8.1.0) |
There was a problem hiding this comment.
new versions should be added on top rather than at the end (so that we see first the recent version)
There was a problem hiding this comment.
@torchello please polish it as it's only dependency left waiting for Drupal to declare compatibility with PHP 8.5
There was a problem hiding this comment.
I was waiting for the prophecy's release. Seeing some network issues in CI now. Will re-trigger later.
There was a problem hiding this comment.
So latest Psalm 6.x release does not support PHP 8.5 :(
https://github.com/vimeo/psalm/blob/6.13.1/composer.json#L22
Seems like we need to wait or migrate to 7.0-beta.
|
I think we should split the CI workflow into different jobs. Coding standard checks and static analysis don't need to be done for all PHP versions, which would allow us to decouple the PHP versions being tested from versions supported by our static analysis tooling. |
3 participants
Resolving #1499