Avoid partial name matching #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
============================================
+ Coverage 93.32% 93.33% +0.01%
- Complexity 492 493 +1
============================================
Files 60 60
Lines 1318 1321 +3
============================================
+ Hits 1230 1233 +3
Misses 88 88
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
@AlessandroMinoccheri can you review it? (github don't permits me to ask it to you, because you created this PR) |
src/Analyzer/PatternString.php
Outdated
| if (!$this->containsWildcard($pattern) && str_starts_with($this->value, $pattern)) { | ||
| return true; | ||
| if (!$this->containsWildcard($pattern)) { | ||
| $slashedTerminatedPattern = str_ends_with($pattern, '\\')? $pattern : $pattern.'\\'; |
Member
Author
There was a problem hiding this comment.
Can we simplify these lines to explicit well the meaning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.