added parsing and checking functions docblocks #302
Conversation
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
============================================
+ Coverage 95.87% 96.06% +0.18%
- Complexity 397 399 +2
============================================
Files 59 59
Lines 1091 1092 +1
============================================
+ Hits 1046 1049 +3
+ Misses 45 43 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
micheleorselli
left a comment
micheleorselli
left a comment
There was a problem hiding this comment.
Noice! Left a minor, non blocking comment
| ); | ||
| } | ||
|
|
||
| if (null !== $this->classDescriptionBuilder && null !== $node->getDocComment()) { |
There was a problem hiding this comment.
do we need the null check on $this->classDescriptionBuilder? I find it a bit confusing, as we are already using $this->classDescriptionBuilder a few lines above without any check
There was a problem hiding this comment.
I have got different errors without this check
There was a problem hiding this comment.
I am not sure I got what you mean but just out of curiosity: doesn't the check on line 28 prevent from having a null in $this->classDescriptionBuilder here?
And just to be super clear: all good from me, feel free to merge it
There was a problem hiding this comment.
The check on line 28 is inside an if that finish before the new check, this check is more generic
There was a problem hiding this comment.
It's a little bit confusing, if tou want to split this method this could be a great refactoring... but if you prefer we can work on it on another PR.
There was a problem hiding this comment.
split the if @fain182 ? What is confusing in this part?
This should fix this issue #301
Is it a BC?