Skip to content

Conversation

@fain182
Copy link
Collaborator

@fain182 fain182 commented Sep 29, 2022

This should fix #290

There are some little things to fix, but the core of the functionality should be here...

  • fix the error on psalm (or change the psalm configuration)
  • add the command in the documentation
  • now it uses the current directory as the default classSet, it's a good idea?
  • improve error handling when there are too few or too many arguments for the Expression
  • it would be great to add all the expressions in the documentation of the command dinamically
  • decide how to manage the php version for the parsing
  • decide if we care about parsing errors

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #294 (a1d6cdd) into main (3086bc9) will increase coverage by 0.15%.
The diff coverage is 96.82%.

@@             Coverage Diff              @@
##               main     #294      +/-   ##
============================================
+ Coverage     95.68%   95.84%   +0.15%     
- Complexity      380      396      +16     
============================================
  Files            58       59       +1     
  Lines          1019     1082      +63     
============================================
+ Hits            975     1037      +62     
- Misses           44       45       +1     
Impacted Files Coverage Δ
src/CLI/Command/DebugExpression.php 96.77% <96.77%> (ø)
src/CLI/PhpArkitectApplication.php 71.42% <100.00%> (+4.76%) ⬆️
src/Expression/ForClasses/NotExtend.php 92.85% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fain182 fain182 force-pushed the expression-test-command branch from f47dff2 to 1964a97 Compare October 8, 2022 10:54
@fain182 fain182 changed the title first draft of debug:expression command debug:expression command Oct 8, 2022
Copy link
Member

@micheleorselli micheleorselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Pietro 💯

@fain182 fain182 merged commit ea5372c into main Oct 10, 2022
@micheleorselli micheleorselli deleted the expression-test-command branch March 13, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve developer experience with a CLI command to test selectors (glob)

5 participants