Parsing enum file #276
Parsing enum file #276
Conversation
AlessandroMinoccheri
force-pushed
the
parse-enum
branch
from
a15a343 to
1422ac5
Compare
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
============================================
+ Coverage 93.51% 93.55% +0.03%
- Complexity 363 367 +4
============================================
Files 57 57
Lines 971 977 +6
============================================
+ Hits 908 914 +6
Misses 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. |
| $violations = new Violations(); | ||
|
|
||
| $notHaveDependencyOutsideNamespace = new Implement('MyInterface'); | ||
| $notHaveDependencyOutsideNamespace->evaluate($cd[0], $violations, 'we want to add this rule for our software'); |
There was a problem hiding this comment.
I am not sure I got the goal of this test
There was a problem hiding this comment.
It's a simple rule @micheleorselli to check if we are parsing or not the enum class.
Without the code inside the FileVisitor the enum class is not parsed and this test it's red.
We can try to find a different test to be more explicit. Any ideas?
| $this->classDescriptions[] = $classDescription; | ||
| } | ||
|
|
||
| if ($node instanceof Node\Stmt\Enum_ && null !== $this->classDescriptionBuilder) { |
There was a problem hiding this comment.
Here we treat enum as a class which is fine for now. I am wondering if we should add a method like isEnum or similar
There was a problem hiding this comment.
What is the benefit to add the method isEnum now?
I think it could be fine.
This PR should fix #275