Skip to content

Conversation

@ostrolucky
Copy link
Collaborator

@ostrolucky ostrolucky commented Aug 27, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets finishes #245
Documentation
License MIT

What's in this PR?

Similarly like symfony/http-client and other bundles, this utilizes symfony/var-dumper to format request/response body messages.

Json detection was partially taken over from csa/guzzle-bundle

This results in much improved design of body formatting, replacing plain nl2br that was used till now.

image

Checklist

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks!

@ostrolucky ostrolucky changed the title Fix tests with newer symfony version [Profiler] Utilize symfony/var-dumper for dumping response body Aug 28, 2021
@dbu
Copy link
Collaborator

dbu commented Aug 29, 2021

thanks!

do you plan to work on fixing the ci setup of the bundle? (i guess we should port it to github actions like we did for other php-http repositories...) while this looks good to me, i'd prefer to see the CI running through before merging ;-)

@ostrolucky
Copy link
Collaborator Author

CI is running, see https://app.travis-ci.com/github/ostrolucky/HttplugBundle/builds. But yes, I plan to move it to GH actions.

@dbu dbu merged commit 836f793 into php-http:master Aug 29, 2021
@dbu
Copy link
Collaborator

dbu commented Aug 29, 2021

oh, github showed travis-ci as outstanding. looks good then, i merged the change.

i let you decide when to tag a release ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants