Update reflecting suggestions since opening final review #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthiasmullie
commented
Dec 9, 2016
matthiasmullie
commented
- Remove CounterInterface from this spec
- Add CacheException & InvalidArgumentException interfaces
- Return success status (bool) on delete, clear & deleteMultiple
- Introduce a default value for getMultiple
- Various documentation clarifications
* Remove CounterInterface from this spec * Add CacheException & InvalidArgumentException interfaces * Return success status (bool) on delete, clear & deleteMultiple * Introduce a default value for getMultiple * Various documentation clarifications
Contributor
|
I assume you copy pasted the interface in here from the other repo 1:1 right? :) I don't have time to check in details right now, but thanks! |
Contributor
Author
|
Yeah. For a minute, I considered mimicking the commits to the spec 1 by 1, but that seemed to cumbersome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.