hal/ia32: cast operands to correct sizes#346
Merged
Conversation
Author
__asm__ volatile(
"inw %1, %0; "
: "=a" (val)
: "d" ((uint16_t)addr));generates whereas __asm__ volatile(
"inw %1, %0; "
: "=a" (val)
: "d" (addr));generares |
Author
|
BTW, why is this code copied 3 times in plo? |
3a81a48 to
04108fa
Compare
14 tasks
04108fa to
6d2ad4d
Compare
agkaminski
reviewed
Sep 23, 2024
hal/ia32/cpu.h
Outdated
| static inline u8 hal_inb(void *addr) | ||
| { | ||
| unsigned char val; | ||
| u32 ioport = (u32)addr; |
Member
There was a problem hiding this comment.
IMHO double cast here is somewhat better (like you did in the kernel). Perhaps move API void * -> u16, if easily done
6d2ad4d to
f6327bc
Compare
Copy "in" related function from efi. Newer binutils versions check closely if asm instructions get operands of correct size. JIRA: RTOS-912
f6327bc to
41d9dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy "in" related function from efi.
Newer binutils versions check closely if asm instructions get operands of correct size.
JIRA: RTOS-912
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment