Skip to content

[DO NOT MERGE] spatial & temporal partitioning#1566

Draft
etiaro wants to merge 1 commit intomasterfrom
etiaro/partitioning
Draft

[DO NOT MERGE] spatial & temporal partitioning#1566
etiaro wants to merge 1 commit intomasterfrom
etiaro/partitioning

Conversation

@etiaro
Copy link
Contributor

@etiaro etiaro commented Feb 24, 2026

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gemini-code-assist
Copy link

Summary of Changes

Hello @etiaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on synchronizing the repository with recent developments in core submodules and making a minor adjustment to a non-volatile memory (NVM) partition offset. While the title suggests work on spatial and temporal partitioning, the visible changes are limited to updating dependencies and a configuration value, likely serving as foundational steps for the broader partitioning effort.

Highlights

  • Submodule Updates: Updated the phoenix-rtos-build, phoenix-rtos-kernel, and plo submodules to their latest respective commits.
  • NVM Partition Offset Adjustment: Modified the user partition offset in the nvm.yaml configuration for the imxrt105x target, increasing it from 0x11000 to 0x12000.
Changelog
  • _targets/armv7m7/imxrt105x/nvm.yaml
    • Increased the offset of the 'user' partition from 0x11000 to 0x12000.
  • phoenix-rtos-build
    • Updated the phoenix-rtos-build submodule to commit 961d5dffc261aef4aaf303b72e5e845a816a5a69.
  • phoenix-rtos-kernel
    • Updated the phoenix-rtos-kernel submodule to commit 888e96232f73b109d9b7817a82bd9361a8c6050e.
  • plo
    • Updated the plo submodule to commit c7dc7127902b3478cbfef1b6b403cd47b7ff36ea.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@etiaro etiaro force-pushed the etiaro/partitioning branch from b648fd1 to d3f893f Compare February 24, 2026 17:37
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the nvm.yaml configuration file by changing the offset for the 'user' partition and updates several subproject commits. The change in nvm.yaml seems to be a functional adjustment, likely to accommodate new partitioning requirements. The subproject updates are routine and reflect changes in dependencies. No critical issues were found, but a minor improvement opportunity in nvm.yaml is noted for clarity.

@etiaro etiaro force-pushed the etiaro/partitioning branch 5 times, most recently from 7ffe583 to 01515a1 Compare February 24, 2026 18:26
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Unit Test Results

9 525 tests  ±0   8 933 ✅ ±0   54m 41s ⏱️ + 1m 54s
  583 suites ±0     592 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit ed491fd. ± Comparison against base commit 639e485.

♻️ This comment has been updated with latest results.

@etiaro etiaro force-pushed the etiaro/partitioning branch 9 times, most recently from 730238f to cf1f514 Compare February 27, 2026 12:13
@etiaro etiaro force-pushed the etiaro/partitioning branch 5 times, most recently from 060155b to 551986f Compare March 5, 2026 13:45
@etiaro etiaro force-pushed the etiaro/partitioning branch from 551986f to ed491fd Compare March 5, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant