lighttpd: lighttpd.conf updates#1262
Conversation
- prefer lighttpd defaults - resource tuning - remove mod_evasive and mod_usertrack (removed from upstream) - comment out modules not otherwise used in lighttpd.conf
|
ping @Darchiv |
There was a problem hiding this comment.
I have left some remarks. Sorry for the delay.
I appreciate that you make the "default" configuration file (as root-skel directory itself suggests) more default. It should probably be moved somewhere else (port's directory in phoenix-rtos-ports?), but there is also the possibility that a per-target configuration is needed for lighttpd to run at all, which would be stored in _phoenix-rtos-project/projects/*/rootfs-overlay/etc, but that's not in scope of this PR. Let's focus on upgrading lighttpd to 1.4.77 and make further improvements when it's done :)
|
@Darchiv ping. |
|
@Darchiv, @agkaminski ping. It has been over a month since @Darchiv provided feedback and I responded the same day to answer questions. Is your intention to discourage contributors? For this PR, the "mod_evasive" and "mod_usertrack" must be removed, as they no longer exist in lighttpd. If you feel unable to accept this PR because you want to change larger things out-of-scope, then please narrow the scope of this PR to remove "mod_evasive" and "mod_usertrack" to unblock phoenix-rtos/phoenix-rtos-ports#90 |
|
@gstrauss Sorry! We're having a very busy time right now. We do intend to merge the PR, I hope we'll be able to do this upcoming week. |
Thank you. I was not trying to rush you; I was merely looking for a response and (reasonable) estimate for when feedback might be provided. A week is fine. So are two weeks if you communicate that expectation. |
Actually, no. I was just cautious so as not to break any of the internal projects we have which use lighttpd. I will merge this as-is. |
lighttpd: lighttpd.conf updates
Description
Motivation and Context
modern lighttpd with bug fixes and HTTP/2 (optional)
fixes issue blocking phoenix-rtos/phoenix-rtos-ports#90
Types of changes
How Has This Been Tested?
Checklist:
Special treatment