Skip to content

lighttpd: lighttpd.conf updates#1262

Merged
Darchiv merged 1 commit intophoenix-rtos:masterfrom
gstrauss:lighttpd.conf
Mar 31, 2025
Merged

lighttpd: lighttpd.conf updates#1262
Darchiv merged 1 commit intophoenix-rtos:masterfrom
gstrauss:lighttpd.conf

Conversation

@gstrauss
Copy link
Contributor

lighttpd: lighttpd.conf updates

Description

  • prefer lighttpd defaults
  • resource tuning
  • remove mod_evasive and mod_usertrack (removed from upstream)
  • comment out modules not otherwise used in lighttpd.conf

Motivation and Context

modern lighttpd with bug fixes and HTTP/2 (optional)
fixes issue blocking phoenix-rtos/phoenix-rtos-ports#90

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

- prefer lighttpd defaults
- resource tuning
- remove mod_evasive and mod_usertrack (removed from upstream)
- comment out modules not otherwise used in lighttpd.conf
@gstrauss
Copy link
Contributor Author

ping @Darchiv

Copy link
Member

@Darchiv Darchiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some remarks. Sorry for the delay.

I appreciate that you make the "default" configuration file (as root-skel directory itself suggests) more default. It should probably be moved somewhere else (port's directory in phoenix-rtos-ports?), but there is also the possibility that a per-target configuration is needed for lighttpd to run at all, which would be stored in _phoenix-rtos-project/projects/*/rootfs-overlay/etc, but that's not in scope of this PR. Let's focus on upgrading lighttpd to 1.4.77 and make further improvements when it's done :)

@gstrauss
Copy link
Contributor Author

gstrauss commented Mar 6, 2025

@Darchiv ping.

@gstrauss
Copy link
Contributor Author

@Darchiv, @agkaminski ping.

It has been over a month since @Darchiv provided feedback and I responded the same day to answer questions. Is your intention to discourage contributors?

For this PR, the "mod_evasive" and "mod_usertrack" must be removed, as they no longer exist in lighttpd. If you feel unable to accept this PR because you want to change larger things out-of-scope, then please narrow the scope of this PR to remove "mod_evasive" and "mod_usertrack" to unblock phoenix-rtos/phoenix-rtos-ports#90

@agkaminski
Copy link
Member

@gstrauss Sorry! We're having a very busy time right now. We do intend to merge the PR, I hope we'll be able to do this upcoming week.

@gstrauss
Copy link
Contributor Author

@gstrauss Sorry! We're having a very busy time right now. We do intend to merge the PR, I hope we'll be able to do this upcoming week.

Thank you. I was not trying to rush you; I was merely looking for a response and (reasonable) estimate for when feedback might be provided. A week is fine. So are two weeks if you communicate that expectation.

@Darchiv
Copy link
Member

Darchiv commented Mar 31, 2025

@Darchiv, @agkaminski ping.

It has been over a month since @Darchiv provided feedback and I responded the same day to answer questions. Is your intention to discourage contributors?

Actually, no. I was just cautious so as not to break any of the internal projects we have which use lighttpd. I will merge this as-is.

@Darchiv Darchiv merged commit 2eda45c into phoenix-rtos:master Mar 31, 2025
@gstrauss gstrauss mentioned this pull request Jun 2, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants