Skip to content

misc: adapt to gcc 14.2 warnings#97

Merged
badochov merged 2 commits intomasterfrom
badochov/gcc-14.2
Mar 17, 2025
Merged

misc: adapt to gcc 14.2 warnings#97
badochov merged 2 commits intomasterfrom
badochov/gcc-14.2

Conversation

@badochov
Copy link
Contributor

@badochov badochov commented Sep 27, 2024

Description

Warnings fixed:

Warning: /github/workspace/phoenix-rtos-lwip/drivers/ephy.c:121:9: warning: 'full_duplex' may be used uninitialized [-Wmaybe-uninitialized]
  121 |         printf("lwip: ephy%u.%u link is %s %uMbps/%s (ctl %04x, status %04x, adv %04x, lpa %04x, pctl %04x,%04x)\n",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  122 |                 phy->bus, phy->addr, linkup ? "UP  " : "DOWN", speed, full_duplex ? "Full" : "Half",
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  123 |                 bctl, bstat, adv, lpa, pc1, pc2);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/github/workspace/phoenix-rtos-lwip/drivers/ephy.c:104:20: note: 'full_duplex' was declared here
  104 |         int speed, full_duplex;
      |                    ^~~~~~~~~~~

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@github-actions
Copy link

github-actions bot commented Sep 27, 2024

Unit Test Results

7 958 tests  +233   7 416 ✅ +406   40m 34s ⏱️ + 3m 25s
  470 suites + 25     542 💤  - 173 
    1 files   ±  0       0 ❌ ±  0 

Results for commit cbb9b88. ± Comparison against base commit b0964a1.

This pull request removes 729 and adds 962 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_e
…
flash ‑ sparcv8leon-generic-qemu:flash
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_aefg.inf_nan_a
…
This pull request removes 137 skipped tests and adds 36 skipped tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_a
phoenix-rtos-tests/libc/scanf ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_e
…
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_brackets
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_c
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_s
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_squareBrackets.white_spaces
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_brackets
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_c
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_s
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_squareBrackets.white_spaces
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_brackets
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/libc/scanf-advanced.stdio_scanf_rest.m_c
…

♻️ This comment has been updated with latest results.

@badochov badochov force-pushed the badochov/gcc-14.2 branch 2 times, most recently from bfeac7a to 4d365cc Compare October 4, 2024 11:01
@Darchiv
Copy link
Member

Darchiv commented Feb 7, 2025

Please update the submodule commit after merge in lib-lwip (also, the summary seems to have a wrong commit name)

Hubert Badocha added 2 commits February 7, 2025 17:04
* lib-lwip ce151524...c450be3c (1):
  > misc: match declaration and definition signatures

JIRA: RTOS-927
@badochov badochov merged commit 52ccef3 into master Mar 17, 2025
36 of 37 checks passed
@badochov badochov deleted the badochov/gcc-14.2 branch March 17, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants