Conversation
14 tasks
badochov
force-pushed
the
badochov/gcc-14.2
branch
from
434c0e3 to
ffe6d59
Compare
Darchiv
reviewed
Oct 8, 2024
Member
Darchiv
left a comment
Darchiv
left a comment
There was a problem hiding this comment.
Minor nitpicks.
Please tick appropriate ticks (at least the type(s) of changes).
rofs/rofs.c
Outdated
|
|
||
| fil->port = ctx->oid.port; | ||
| if (name == NULL) { | ||
| if ((name == NULL) || (name[0] == '\0')) { |
Member
There was a problem hiding this comment.
In case of name[0] == '\0', dirfind() returns -ENOENT, so this should also be the case here. Maybe initialize res with -ENOENT or add a separate if?
rofs/rofs.c
Outdated
|
|
||
| while (name[len] != '\0') { | ||
| while (name[len] == '/' && name[len] != '\0') { | ||
| while ((name[len] == '/') && (name[len] != '\0')) { |
Member
There was a problem hiding this comment.
Just noticed this - if name[0] == '/', then it certainly isn't '\0'
JIRA: RTOS-927
badochov
force-pushed
the
badochov/gcc-14.2
branch
from
ffe6d59 to
538f710
Compare
badochov
changed the title
Darchiv
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-927
Description
If "\0" was passed unitialzed
reswould be returnedMotivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment