sys/threads: modify threadsinfo declaration

[oI0ck]

JIRA: RTOS-1187

Description

This pull request adjusts the function declaration to respective changes in the kernel

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: (add PR link here).
• Tested by hand on: (list targets here).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• !syscalls/threadsinfo: return more granular thread information phoenix-rtos-kernel#720
• psh: modify threadsinfo calls according to kernel changes phoenix-rtos-utils#251
• kernel: document threadsinfo modifications phoenix-rtos-doc#247
• I will merge this PR by myself when appropriate.

[gemini-code-assist]

Summary of Changes

Hello @oI0ck, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a necessary adjustment to the threadsinfo function's declaration within the system's threading interface. This modification is a direct response to underlying changes in the kernel, ensuring compatibility and proper functionality. As a result, this change is classified as a breaking change, requiring updates to any code that calls this function.

Highlights

• threadsinfo function signature update: The threadsinfo function declaration in include/sys/threads.h has been updated to include two new parameters: int *tid and unsigned int flags. This modification is a breaking change, as indicated in the pull request description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the function signature for threadsinfo in sys/threads.h to align with kernel changes, adding tid and flags parameters. This is a breaking change. My review focuses on the maintainability and clarity of this API modification. I have added a comment recommending the addition of documentation for the new parameters to clarify their purpose and usage, which is crucial for a public-facing API.

[ziemleszcz]

Breaking commits should be marked by !.

[ziemleszcz]

Add kernel PR to the list list of additional PRs.

[ziemleszcz]

I don't like this API change. The function has become too complex. I'd rather add additional syscall wrappers to preserve backward compatibility:

/* The same as old API. Returns thread count if info==NULL? */
int threadsinfo(int n, threadinfo_t *info)

/* Adds flags argument. */
int threadsinfo3(int n, threadinfo_t *info, unsigned int flags);

/* Single thread info, not sure if we need flags here. Returns 0 on success? */
int threadinfo(int tid, threadinfo_t *info, unsigned int flags)

[oI0ck]

There would be a symbol collision if I were to change threadsinfo() declaration here.

[oI0ck]

To achieve what you are describing here, I'd have to rename the syscall in the kernel.
IMHO the function (or it's declaration) is not overly complex.