Skip to content

Conversation

@marcofranssen
Copy link
Member

@marcofranssen marcofranssen commented Jan 20, 2021

This PR adds authenticating tabia as a Github App.

Current implementation will limit the GitHub App authentication to a single organization, whereas the token based auth allows to fetch information from multiple organizations at a time.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #88 (a34b1d0) into develop (b39b7a5) will decrease coverage by 0.45%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
- Coverage    66.66%   66.21%   -0.46%     
===========================================
  Files           17       18       +1     
  Lines          408      438      +30     
===========================================
+ Hits           272      290      +18     
- Misses         117      129      +12     
  Partials        19       19              
Flag Coverage Δ
unittests 66.21% <60.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/github/app.go 60.00% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39b7a5...a34b1d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants