Skip to content

Fallback for Web Audio on Firefox #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Fallback for Web Audio on Firefox #7083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/sound/webaudio/WebAudioSoundManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ var WebAudioSoundManager = new Class({
var context = this.context;

// setTimeout to avoid weird audio artifacts (thanks Apple)
window.setTimeout(function () {
window.setTimeout(function ()
{

if (context)
{
Expand Down Expand Up @@ -429,11 +430,12 @@ var WebAudioSoundManager = new Class({
{
var listener = this.context.listener;

var x = GetFastValue(this.listenerPosition, 'x', null);
var y = GetFastValue(this.listenerPosition, 'y', null);


if (listener && listener.positionX !== undefined)
{
var x = GetFastValue(this.listenerPosition, 'x', null);
var y = GetFastValue(this.listenerPosition, 'y', null);

if (x && x !== this._spatialx)
{
this._spatialx = listener.positionX.value = x;
Expand All @@ -444,6 +446,24 @@ var WebAudioSoundManager = new Class({
}
}

// Firefox doesn't currently implement positionX, positionY and positionZ properties on AudioListener,
// falling back on AudioListener.prototype.setPosition() method. @see https://developer.mozilla.org/en-US/docs/Web/API/AudioListener/setPosition
else if (listener)
{
if (x && x !== this._spatialx)
{
this._spatialx = x;
}
if (y && y !== this._spatialy)
{
this._spatialy = y;
}

var z = GetFastValue(listener, 'z', 0);

listener.setPosition(this._spatialx || 0, this._spatialy || 0, z);
}

BaseSoundManager.prototype.update.call(this, time, delta);

// Resume interrupted audio on iOS only if the game has focus
Expand Down