Fix 2923 building under mingw64 windows msys2

[cvvergara]

Fixes #2923 .

Changes proposed in this pull request:

• Removing warnings in windows compilation
• Fixing by reordering include directive

@pgRouting/admins

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cvvergara]

Now we have the same problem with metrics_process.cpp and probably ordering_process.cpp (compilation halts on first error):
https://winnie.postgis.net/job/pgRouting_PGVersionEDB/11304/console

[  3%] �[32mBuilding CXX object src/metrics/CMakeFiles/metrics.dir/metrics_process.cpp.obj�[0m
cd /E/jenkins/pgrouting/builddevelopw64gcc81/src/metrics && /C/ming64gcc81/mingw64/bin/c++.exe -DBOOST_ALLOW_DEPRECATED_HEADERS -DPGSQL_VERSION=18000 -DPROJECT_VERSION=\"4.0.0-dev\" @CMakeFiles/metrics.dir/includes_CXX.rsp -frounding-math  -g -Wall -pedantic -W -Wunused -Wuninitialized -Wextra -Wdouble-promotion -std=c++17   -Wsign-conversion -MD -MT src/metrics/CMakeFiles/metrics.dir/metrics_process.cpp.obj -MF CMakeFiles/metrics.dir/metrics_process.cpp.obj.d -o CMakeFiles/metrics.dir/metrics_process.cpp.obj -c /E/jenkins/pgrouting/branches/develop/src/metrics/metrics_process.cpp
In file included from E:/jenkins/postgresql/rel/pg18w64gcc81/include/server/port.h:24,
                 from E:/jenkins/postgresql/rel/pg18w64gcc81/include/server/c.h:1345,
                 from E:/jenkins/postgresql/rel/pg18w64gcc81/include/server/postgres.h:48,
                 from E:/jenkins/pgrouting/branches/develop/include/c_common/postgres_connection.h:35,
                 from E:/jenkins/pgrouting/branches/develop/src/metrics/metrics_process.cpp:38:
E:/jenkins/postgresql/rel/pg18w64gcc81/include/server/port/win32_port.h:254:8: error: redefinition of 'struct stat'
 struct stat      /* This should match struct __stat64 */
        ^~~~
In file included from C:/ming64gcc81/mingw64/x86_64-w64-mingw32/include/wchar.h:424,
                 from C:/ming64gcc81/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/cwchar:44,
                 from C:/ming64gcc81/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/bits/postypes.h:40,
                 from C:/ming64gcc81/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/bits/char_traits.h:40,
                 from C:/ming64gcc81/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/string:40,
                 from E:/jenkins/pgrouting/branches/develop/src/metrics/metrics_process.cpp:35:
C:/ming64gcc81/mingw64/x86_64-w64-mingw32/include/_mingw_stat64.h:43:10: note: previous definition of 'struct stat'
   struct stat {
          ^~~~
make[2]: *** [src/metrics/CMakeFiles/metrics.dir/build.make:140: src/metrics/CMakeFiles/metrics.dir/metrics_process.cpp.obj] Error 1
make[2]: Leaving directory '/projects/pgrouting/builddevelopw64gcc81'
make[1]: *** [CMakeFiles/Makefile2:2317: src/metrics/CMakeFiles/metrics.dir/all] Error 2
make[1]: Leaving directory '/projects/pgrouting/builddevelopw64gcc81'
make: *** [Makefile:139: all] Error 2
***************************

will use the same fix