Cleanup the build update script

[cvvergara]

Changes proposed in this pull request:

• Refactoring the build update script
  • everything in v2 gets dropped as we do not test the update from v2.6
  • All functions marked as created on v2.6 now are marked as 3.0

@pgRouting/admins

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cvvergara]

@coderabbitai summary
@coderabbitai review

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@cvvergara I'll generate both a summary and conduct a review of this PR. Let me first gather the necessary information about the changes.

---

🏁 Script executed:

#!/bin/bash
# Get PR details and metadata
gh pr view 2903 --json title,body,author,createdAt,headRefName,baseRefName,state,mergeable,additions,deletions,changedFiles

# Get the list of files changed in this PR
gh pr diff 2903 --name-only

# Get the actual diff content
gh pr diff 2903

Length of output: 54073

---

@cvvergara Here's the summary and review for PR #2903:

Summary

Title: Cleanup the build update script
Author: Vicky Vergara
Branch: cleanup-the-build-update-script → develop
Status: Open, Mergeable
Changes: 41 files modified (+155/-572 lines)

Purpose

This PR refactors the PostgreSQL extension update script infrastructure by:

• Dropping legacy v2.x support: Removes all update logic for versions 2.0-2.5, only retaining v2.6+ references
• Version standardization: Changes all SQL functions from --v2.6 markers to --v3.0 markers
• Script simplification: Significantly reduces complexity in build-extension-update-files.pl by removing version-specific update functions

Key Changes

1. Build Script Refactoring (sql/scripts/build-extension-update-files.pl)

• Removed version regex patterns for v2.0-2.5 (keeping only v2.6+)
• Eliminated 400+ lines of version-specific update logic
• Simplified upgrade script generation by removing complex legacy handling
• Streamlined function dropping logic for major version transitions

2. SQL Function Version Updates

• Systematic change from --v2.6 to --v3.0 across 38 SQL files
• Affects core routing functions: Dijkstra, A*, bidirectional algorithms, flow algorithms, VRP, TSP, and utility functions

3. Documentation Updates

• Updated NEWS.md and release notes to document the script refactoring
• Updated localization files (POT/PO) with new translation strings

Impact

• Maintenance benefit: Reduces technical debt by dropping support for very old versions
• Simplified upgrades: Cleaner upgrade path focusing on supported version ranges
• Code reduction: Net reduction of 417 lines demonstrates significant simplification
• No functional changes: This is purely infrastructure cleanup without algorithmic modifications

---

Code Review

Build Script Analysis ✅

The Perl script refactoring is well-executed:

Strengths:

• Clear removal of obsolete version handling (v2.0-2.5)
• Logical consolidation of upgrade logic
• Improved code organization with better separation of concerns
• Enhanced documentation explaining signature handling and update mechanisms

Key Improvements:

# Before: Complex version-specific functions for each minor version
# After: Simplified logic focusing on supported versions only

# Cleaner approach to function dropping
if ($old_mayor == 2) {
    push @commands, drop_special_case_function($old_function);
    next;
}

SQL Version Marker Changes ✅

The systematic update from --v2.6 to --v3.0 is consistent across all files:

Positive aspects:

• Uniform application across all affected SQL files
• Maintains compatibility with the new script logic
• Clear version baseline establishment

Files Updated: 38 SQL files covering:

• Core algorithms (Dijkstra, A*, bidirectional)
• Flow algorithms (max flow, edge-disjoint paths)
• Specialized functions (VRP, TSP, with-points)
• Utility functions

Documentation & Localization ✅

NEWS.md and release notes:

• Appropriately documents the infrastructure change
• Clear description of the refactoring purpose

Translation files:

• Properly updated POT/PO files with new strings
• Maintains localization consistency

Risk Assessment 🟡

Low Risk Areas:

• Documentation changes
• Script simplification (removes complexity)
• Version marker updates (systematic and consistent)

Medium Risk Areas:

• Extension upgrade logic changes
• Need to verify upgrade paths work correctly from supported versions

Recommendations

1. Testing Priority: Focus testing on extension upgrades from v2.6 and v3.x versions to ensure the simplified logic works correctly

2. Documentation: Consider adding a migration guide for users still on v2.0-2.5 versions

3. Validation: Verify that the drop_special_case_function logic properly handles all edge cases during major version upgrades

Overall Assessment

This is a well-structured maintenance PR that successfully reduces technical debt while maintaining functionality. The systematic approach to version marker updates and script simplification demonstrates careful planning. The significant line reduction (572 deletions vs 155 additions) indicates effective cleanup without compromising essential functionality.

Recommendation: Approve ✅

The changes are focused, well-documented, and represent a positive step toward simpler maintenance of the pgRouting extension infrastructure.

🐰💭 Thoughtful refactoring always makes my developer heart happy! This kind of technical debt cleanup is essential for long-term project health.